Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always delete digital ocean key for test_key_management test #53494

Merged
merged 4 commits into from Jun 19, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented Jun 14, 2019

What does this PR do?

The test integration.cloud.clouds.test_digitalocean.DigitalOceanTest.test_key_management is not always cleaning up the key, so on the next test run it fails.

What issues does this PR fix or reference?

#53010

Tests written?

fixes test

Commits signed with GPG?

Yes

@dwoz
dwoz approved these changes Jun 14, 2019
@Ch3LL

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

re-run full all

Ch3LL and others added 2 commits Jun 18, 2019
@garethgreenaway garethgreenaway self-requested a review Jun 18, 2019
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jun 18, 2019
@Ch3LL Ch3LL merged commit 8c2e952 into saltstack:2019.2.1 Jun 19, 2019
12 of 17 checks passed
12 of 17 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.