Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move create key call into try/except in Digital Ocean key test #53562

Merged
merged 3 commits into from Jul 2, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented Jun 21, 2019

What does this PR do?

Fixes test integration.cloud.clouds.test_digitalocean.DigitalOceanTest.test_key_management. Sometimes this test fails and the key does not get cleaned up because the create_key call is not in the try/except/finally. I've re-ran the test about 10 times and it passes each time now.

What issues does this PR fix or reference?

#53010

Previous Behavior

test integration.cloud.clouds.test_digitalocean.DigitalOceanTest.test_key_management fails

New Behavior

test integration.cloud.clouds.test_digitalocean.DigitalOceanTest.test_key_management passes

Tests written?

No - fixes tests

Commits signed with GPG?

Yes

Ch3LL added 2 commits Jun 21, 2019
@Ch3LL Ch3LL merged commit 8857dbd into saltstack:2019.2.1 Jul 2, 2019
32 of 40 checks passed
32 of 40 checks passed
ci/py2/fedora29 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py2/ubuntu1604 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py2/ubuntu1804 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py2/windows2016 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/fedora29 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/ubuntu1604 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/windows2016 (ignore-me-new-jenkins) This commit cannot be built
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has failed
Details
WIP Ready for review
Details
ci/docs (ignore-me-new-jenkins) This commit looks good
Details
ci/lint (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos6 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint test passed
Details
jenkins/pr/py2-amazon-2 The py2-amazon-2 job has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-fedora-29 The py2-fedora-29 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-amazon-2 The py3-amazon-2 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-fedora-29 The py3-fedora-29 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.