Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitelist errors in `test_boto_*` state tests on Windows #53591

Merged
merged 4 commits into from Jul 7, 2019

Conversation

@twangboy
Copy link
Contributor

commented Jun 24, 2019

What does this PR do?

Fixes the unit.state.test_boto_* tests that were throwing errors because reg is not in the whitelist.

What issues does this PR fix or reference?

Jenkins errors:

test_present_when_trail_does_not_exist (unit.states.test_boto_cloudtrail.BotoCloudTrailTestCase)
[CPU:19.7%|MEM:66.7%]  ... 17:33:10,445 [salt.loader                                               :1739][ERROR   ] Failed to load function reg.read_value because its module (reg) is not in the whitelist: ['boto', 'boto3', 'args', 'systemd', 'path', 'platform']
17:33:22,228 [salt.loader                                               :1845][ERROR   ] Exception raised when processing __virtual__ function for salt.loaded.int.module.win_snmp. Module will not be loaded: 'reg.key_exists'

Tests written?

Yes

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from cmcmarrow Jun 26, 2019
garethgreenaway and others added 3 commits Jul 5, 2019
@twangboy twangboy merged commit 1756156 into saltstack:2019.2.1 Jul 7, 2019
1 of 2 checks passed
1 of 2 checks passed
jenkins/pr/docs Testing docs...
Details
WIP Ready for review
Details
@codecov

This comment has been minimized.

Copy link

commented Jul 7, 2019

Codecov Report

Merging #53591 into 2019.2.1 will decrease coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           2019.2.1   #53591     +/-   ##
===========================================
- Coverage     37.41%   36.72%   -0.7%     
===========================================
  Files          1577     1577             
  Lines        269748   269748             
  Branches      57512    57512             
===========================================
- Hits         100938    99056   -1882     
- Misses       157491   159523   +2032     
+ Partials      11319    11169    -150
Flag Coverage Δ
#amazon2 36.72% <ø> (+1.24%) ⬆️
#centos7 ?
#py2 36.46% <ø> (-0.39%) ⬇️
#py3 35.92% <ø> (-0.68%) ⬇️
#tornado ?
#ubuntu1604 ?
Impacted Files Coverage Δ
salt/sdb/vault.py 0% <0%> (-55.56%) ⬇️
salt/states/docker_network.py 9.12% <0%> (-52.29%) ⬇️
salt/states/zookeeper.py 8.52% <0%> (-51.94%) ⬇️
salt/modules/zookeeper.py 25.92% <0%> (-51.86%) ⬇️
salt/states/docker_container.py 5.31% <0%> (-46.46%) ⬇️
salt/pillar/git_pillar.py 35.59% <0%> (-40.68%) ⬇️
tests/integration/files/engines/runtests_engine.py 34.32% <0%> (-37.32%) ⬇️
salt/modules/aptpkg.py 21.45% <0%> (-30.41%) ⬇️
salt/utils/pkg/deb.py 31.57% <0%> (-26.32%) ⬇️
salt/modules/dpkg_lowpkg.py 32.38% <0%> (-23.34%) ⬇️
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464464c...ba8ba26. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.