Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow yaml list notation for nodegroup expansion #53624

Merged
merged 4 commits into from Jul 2, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented Jun 27, 2019

What does this PR do?

Defining Nodegroups as lists of minions was added in 2016.11.0 (https://docs.saltstack.com/en/latest/topics/targeting/nodegroups.html#defining-nodegroups-as-lists-of-minion-ids), this does not work for nodegroups that target other nodegroups.

What issues does this PR fix or reference?

#42735

Previous Behavior

Given this config:

nodegroups:
  - free1:
    - newrecipe
    - minion2
  - group1: 'N@free1'

you would not be able to target group1

(salt-py2) ➜  salt git:(0ca04ffbeb) sudo salt -N group1 test.version
No minions matched the target. No command was sent, no jid was assigned.
ERROR: No return received
(salt-py2) ➜  salt git:(0ca04ffbeb) 

New Behavior

(salt-py2) ➜  salt git:(nodegroup_group_list) sudo salt -N group1 test.version
newrecipe:
    2019.2.0-386-gd236bd4
minion2:
    2019.2.0-386-gd236bd4

Tests written?

Yes

Commits signed with GPG?

Yes

Ch3LL added 2 commits Jun 27, 2019
@Ch3LL Ch3LL merged commit 02461cb into saltstack:2019.2.1 Jul 2, 2019
35 of 40 checks passed
35 of 40 checks passed
ci/py2/fedora29 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py2/ubuntu1604 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/fedora29 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/ubuntu1604 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/windows2016 (ignore-me-new-jenkins) This commit cannot be built
Details
WIP Ready for review
Details
ci/docs (ignore-me-new-jenkins) This commit looks good
Details
ci/lint (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos6 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/windows2016 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint test passed
Details
jenkins/pr/py2-amazon-2 The py2-amazon-2 job has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-fedora-29 The py2-fedora-29 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-amazon-2 The py3-amazon-2 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-fedora-29 The py3-fedora-29 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.