Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update win_lgpo #53662

Merged
merged 3 commits into from Jul 2, 2019

Conversation

@lomeroe
Copy link
Contributor

commented Jun 28, 2019

What does this PR do?

Updates win_lgop to handle empty text elements in ADML xml templates

What issues does this PR fix or reference?

#53532

Previous Behavior

ADML entries with empty text elements would throw an exception

New Behavior

Empty text elements are handled properly

Tests written?

Yes

test_win_lgpo updated to handle testing User based policies to accommodate testing this situation on server OSes

Commits signed with GPG?

No

lomeroe added 2 commits Jun 28, 2019
fixes #53532

update test to handle "user" policy class test
@xeacott

This comment has been minimized.

Copy link

commented Jul 1, 2019

re-run full all

@twangboy twangboy added the 2019.2.1 label Jul 1, 2019
@twangboy twangboy self-assigned this Jul 1, 2019
@Akm0d
Akm0d approved these changes Jul 2, 2019
@cmcmarrow cmcmarrow merged commit 015b048 into saltstack:2018.3 Jul 2, 2019
24 of 36 checks passed
24 of 36 checks passed
ci/py2/ubuntu1604 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py2/windows2016 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/fedora29 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/ubuntu1604 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/ubuntu1804 (ignore-me-new-jenkins) This commit cannot be built
Details
ci/py3/windows2016 (ignore-me-new-jenkins) This commit cannot be built
Details
continuous-integration/jenkins/pr-head This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-fedora-29 The py3-fedora-29 job has failed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
ci/docs (ignore-me-new-jenkins) This commit looks good
Details
ci/lint (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos6 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/fedora29 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian9 (ignore-me-new-jenkins) This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint test passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-fedora-29 The py2-fedora-29 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
twangboy added a commit to twangboy/salt that referenced this pull request Jul 2, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 5, 2019
twangboy added a commit that referenced this pull request Jul 7, 2019
Merge Forward #53662 (2019.2.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.