Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LGPO when string object is None #53678

merged 5 commits into from Jul 2, 2019


Copy link

commented Jul 1, 2019

What does this PR do?

Return encoded null when string value is None. Encode to utf-16-le otherwise. Raise an error if a string value is not passed. Add some tests.

What issues does this PR fix or reference?


Tests written?


Commits signed with GPG?


@twangboy twangboy requested review from lomeroe and saltstack/team-windows Jul 1, 2019
@twangboy twangboy added the 2019.2.1 label Jul 1, 2019
Copy link

left a comment

It did work!

@Ch3LL Ch3LL requested a review from cmcmarrow Jul 2, 2019
twangboy added 2 commits Jul 2, 2019
Makes it easier to unit test
@twangboy twangboy removed the Needs Testcase label Jul 2, 2019
dwoz approved these changes Jul 2, 2019
lomeroe approved these changes Jul 2, 2019
@twangboy twangboy merged commit 491bfa8 into saltstack:2019.2.1 Jul 2, 2019
1 of 2 checks passed
1 of 2 checks passed
jenkins/pr/docs Testing docs...
WIP Ready for review
@twangboy twangboy deleted the twangboy:fix_lock_1688_lgpo branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
6 participants
You can’t perform that action at this time.