Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare issue in lgpo state module #53682

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@twangboy
Copy link
Contributor

commented Jul 2, 2019

What does this PR do?

The state was failing when the current policy and the new policy were differing types.
Creates a _compare_policies helper function to determine if policies are the same.
Compares dicts to dicts and lists to lists. Otherwise, returns False
Adds some unit tests

What issues does this PR fix or reference?

saltstack/lock#1740

Tests written?

Yes

Commits signed with GPG?

Yes

Compare dicts to dicts and lists to lists
Return False otherwise
Add some tests
@twangboy twangboy requested review from lomeroe and saltstack/team-windows Jul 2, 2019
@twangboy twangboy added the 2019.2.1 label Jul 2, 2019
@twangboy twangboy self-assigned this Jul 2, 2019
@lomeroe
lomeroe approved these changes Jul 2, 2019
Copy link

left a comment

Did work! thanks @twangboy

@dwoz
dwoz approved these changes Jul 2, 2019
@twangboy twangboy merged commit 727843c into saltstack:2019.2.1 Jul 3, 2019
1 check passed
1 check passed
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.