Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Disabling test_get_set_computer_name on OS X and Py3 #53728

Conversation

@garethgreenaway
Copy link
Member

commented Jul 5, 2019

What does this PR do?

Disabling test_get_set_computer_name on OS X and Py3.

What issues does this PR fix or reference?

N/A

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jul 5, 2019
@pull-assigner pull-assigner bot requested review from Ch3LL and removed request for saltstack/team-core Jul 5, 2019
@waynew

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Per our discussion, we're disabling this until #53566 gets merged. We're testing the theory that the round-trip is causing a hang for some reason.

@waynew

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@garethgreenaway apparently you're missing a six import 😑

Copy link
Contributor

left a comment

Need that six import, then 👍

@waynew
waynew approved these changes Jul 5, 2019
…_computer_name
@waynew
waynew approved these changes Jul 8, 2019
@Ch3LL
Ch3LL approved these changes Jul 8, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Merging without PR tests because they are flaky ATM

@dwoz dwoz merged commit 15accef into saltstack:2019.2.1 Jul 19, 2019
37 of 40 checks passed
37 of 40 checks passed
ci/py2/windows2016 (ignore-me-new-jenkins) This commit cannot be built
Details
continuous-integration/jenkins/pr-head This commit cannot be built
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
ci/docs (ignore-me-new-jenkins) This commit looks good
Details
ci/lint (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos6 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/fedora29 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/ubuntu1604 (ignore-me-new-jenkins) This commit looks good
Details
ci/py2/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/amazon2 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/fedora29 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1604 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/windows2016 (ignore-me-new-jenkins) This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint test passed
Details
jenkins/pr/py2-amazon-2 The py2-amazon-2 job has passed
Details
jenkins/pr/py2-centos-6 The py2-centos-6 job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-debian-8 The py2-debian-8 job has passed
Details
jenkins/pr/py2-debian-9 The py2-debian-9 job has passed
Details
jenkins/pr/py2-fedora-29 The py2-fedora-29 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-ubuntu-1804 The py2-ubuntu-1804 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-amazon-2 The py3-amazon-2 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-fedora-29 The py3-fedora-29 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.