Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call potentially missing shade library #53734

Merged
merged 2 commits into from Jul 6, 2019

Conversation

@Akm0d
Copy link
Contributor

commented Jul 5, 2019

What does this PR do?

See title

What issues does this PR fix or reference?

#53012

@Akm0d Akm0d added the Needs Testcase label Jul 6, 2019
@Akm0d Akm0d removed the Needs Testcase label Jul 6, 2019
@Akm0d Akm0d changed the title [WIP] Don't call potentially missing shade library Don't call potentially missing shade library Jul 6, 2019
@Akm0d Akm0d merged commit c18dfc8 into saltstack:develop Jul 6, 2019
21 checks passed
21 checks passed
WIP Ready for review
Details
ci/docs (ignore-me-new-jenkins) This commit looks good
Details
ci/lint (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/centos7 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian8 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/debian9 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/fedora29 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1604 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/ubuntu1804 (ignore-me-new-jenkins) This commit looks good
Details
ci/py3/windows2016 (ignore-me-new-jenkins) This commit looks good
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint test passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-debian-8 The py3-debian-8 job has passed
Details
jenkins/pr/py3-debian-9 The py3-debian-9 job has passed
Details
jenkins/pr/py3-fedora-29 The py3-fedora-29 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1804 The py3-ubuntu-1804 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@Akm0d Akm0d deleted the Akm0d:cloud_tests branch Jul 6, 2019
@Akm0d

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

Doesn't need a new test case because this PR causes previously failing tests to pass.

@cmcmarrow cmcmarrow self-requested a review Jul 9, 2019
nkukard added a commit to nkukard/salt that referenced this pull request Jul 16, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
johnclyde added a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 7, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 8, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
dwoz added a commit that referenced this pull request Aug 9, 2019
Don't call potentially missing shade library (#53734)
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 21, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 22, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 22, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.