Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory error when the test suite cleans up (2019.2.1) #53750

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@twangboy
Copy link
Contributor

commented Jul 8, 2019

What does this PR do?

This should fix an error that occurs at the end of the test run on Windows... causing the test suite to report failure

An un-handled exception was caught by salt's global exception handler:
22:22:16        OSError: [WinError 299] Only part of a ReadProcessMemory or WriteProcessMemory request was completed: 'originated from ReadProcessMemory(ProcessParameters)'
22:22:16        Traceback (most recent call last):
22:22:16          File "tests\runtests.py", line 914, in <module>
22:22:16            main()
22:22:16          File "tests\runtests.py", line 907, in main
22:22:16            parser.finalize(0)
22:22:16          File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\tests\support\parser\cover.py", line 238, in finalize
22:22:16            SaltTestingParser.finalize(self, exit_code)
22:22:16          File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\tests\support\parser\__init__.py", line 846, in finalize
22:22:16            helpers.terminate_process(children=children, kill_children=True)
22:22:16          File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\tests\support\helpers.py", line 1325, in terminate_process
22:22:16            terminate_process_list(process_list, kill=slow_stop is False, slow_stop=slow_stop)
22:22:16          File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\tests\support\helpers.py", line 1269, in terminate_process_list
22:22:16            _terminate_process_list(process_list, kill=kill, slow_stop=slow_stop)
22:22:16          File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\tests\support\helpers.py", line 1214, in _terminate_process_list
22:22:16            cmdline = process.cmdline()
22:22:16          File "c:\users\admini~1\appdata\local\temp\kitchen\testing\.nox\runtests-parametrized-3-coverage-true-crypto-none-transport-zeromq\lib\site-packages\psutil\__init__.py", line 786, in cmdline
22:22:16            return self._proc.cmdline()
22:22:16          File "c:\users\admini~1\appdata\local\temp\kitchen\testing\.nox\runtests-parametrized-3-coverage-true-crypto-none-transport-zeromq\lib\site-packages\psutil\_pswindows.py", line 667, in wrapper
22:22:16            return fun(self, *args, **kwargs)
22:22:16          File "c:\users\admini~1\appdata\local\temp\kitchen\testing\.nox\runtests-parametrized-3-coverage-true-crypto-none-transport-zeromq\lib\site-packages\psutil\_pswindows.py", line 745, in cmdline
22:22:16            ret = cext.proc_cmdline(self.pid, use_peb=True)

Tests written?

Fixes Tests

Commits signed with GPG?

Yes

@twangboy twangboy changed the title Fix memory error when the test suite cleans up Fix memory error when the test suite cleans up (2019.2.1) Jul 15, 2019
@dwoz
dwoz approved these changes Jul 16, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Merging without PR tests to fast track the windows fix. (3 approvals)

@dwoz dwoz merged commit 317d9af into saltstack:2019.2.1 Jul 16, 2019
16 of 20 checks passed
16 of 20 checks passed
ci/py2/centos6 This commit cannot be built
Details
ci/py2/debian8 This commit cannot be built
Details
ci/py3/centos7 This commit cannot be built
Details
ci/py3/windows2016 This commit cannot be built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.