Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional warnings to test.configurable_test_state #53959

Merged
merged 4 commits into from Dec 24, 2019

Conversation

max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Jul 23, 2019

What does this PR do?

Add optional warnings argument to test.configurable_test_state.

The PR is backward-compatible, non-intrusive and involves a test module (shouldn't be very mission-critical). Please consider merging it into the oldest supported branch, so it won't be necessary to wait for another six months.

What issues does this PR fix or reference?

This is useful to inject warnings into a highstate process. Unlike the salt.log.warning jinja function, the warnings are propagated back to a master.

As per the mailing list request: https://groups.google.com/forum/#!topic/salt-users/4yrxKtNycsk

Tests written?

Yes

Commits signed with GPG?

No

@max-arnold max-arnold requested a review from as a code owner Jul 23, 2019
@ghost ghost requested a review from xeacott Jul 23, 2019
@xeacott
Copy link
Contributor

@xeacott xeacott commented Jul 24, 2019

Hi @max-arnold this PR looks great! I'm just waiting to see whats up with the failing checks. Will get back soon on this.

xeacott
xeacott approved these changes Aug 1, 2019
@max-arnold max-arnold force-pushed the configurable-test-state-warning branch from c3dab2c to 415b280 Compare Oct 1, 2019
@max-arnold max-arnold changed the base branch from 2018.3 to master Oct 14, 2019
@max-arnold max-arnold force-pushed the configurable-test-state-warning branch from 415b280 to aeeeab0 Compare Oct 14, 2019
@max-arnold max-arnold force-pushed the configurable-test-state-warning branch 2 times, most recently from abe1081 to 3c9b1b7 Compare Nov 15, 2019
@max-arnold max-arnold force-pushed the configurable-test-state-warning branch 2 times, most recently from 765c03b to fcd3099 Compare Dec 13, 2019
@max-arnold max-arnold force-pushed the configurable-test-state-warning branch from fcd3099 to e52b848 Compare Dec 19, 2019
@max-arnold
Copy link
Contributor Author

@max-arnold max-arnold commented Dec 19, 2019

@Akm0d The only thing I forgot is to change the versionadded:: 2018.3.5 to Neon. Upd: DONE

@max-arnold max-arnold force-pushed the configurable-test-state-warning branch from 3367ade to ec4fb4f Compare Dec 22, 2019
waynew
waynew approved these changes Dec 23, 2019
@dwoz dwoz merged commit a58459c into saltstack:master Dec 24, 2019
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants