Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[2019.2.1] Add pygit2 requirement #53974
This is likely a Bad Idea
pygit2 has a number of non-Python dependencies, especially if you want SSH support. libffi, libssh, and libgit2 at minimum. Then there's the fact that pygit2 is developed alongside libgit2, and its minor releases must track with the version of libgit2 which is installed. Assuming you have installed libgit2, if a 0.24.x libgit2 release is what you have installed (because that was what was available from the upstream repos), and pip installs pygit2 0.28.2.... in the immortal words of Thumper, "you're gonna have a bad time".
One other thing to consider is that the wheels built for pygit2 may or may not have been built against libssh2 (I haven't tested them), and if they haven't then installing them would leave you with a pygit2 that can't do ssh authentication.
Also, are these "static" requirements files only being used for the test suite?
Are you stating its a bad idea to use the pygit2 pip packages? Are you suggesting we only use system packages which is what we were doing previously in our test suite with our salt-jenkins states. All of the pygit2 tests are passing on this PR.
And yes these requirements files are only for tests. Without this change the pygit2 tests are not running.
I just installed the wheel into a virtualenv. The good news is that the wheel bundles its own