Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyton3 digitial ocean test fix: to_str on key #54038

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@Ch3LL
Copy link
Contributor

commented Jul 26, 2019

What does this PR do?

Fixes the test failure: integration.cloud.clouds.test_digitalocean.DigitalOceanTest.test_key_management

on python3 cloud tests by ensuring the key is a string type.

What issues does this PR fix or reference?

NA

Previous Behavior

Test was failing on python3:

Traceback (most recent call last):
  File "/tmp/kitchen/testing/tests/integration/cloud/clouds/test_digitalocean.py", line 111, in test_key_management
    key_hex = hashlib.md5(base64.b64decode(pub.strip().split()[1].encode())).hexdigest()
AttributeError: 'bytes' object has no attribute 'encode'

New Behavior

Test passes on python2 and python3

Tests written?

No - Fixing a test

Commits signed with GPG?

Yes

@waynew
waynew approved these changes Jul 26, 2019
@dwoz
dwoz approved these changes Jul 29, 2019
@dwoz dwoz merged commit 4aed833 into saltstack:2019.2.1 Jul 29, 2019
21 of 24 checks passed
21 of 24 checks passed
ci/py2/amazon2 This commit cannot be built
Details
ci/py2/centos7 This commit cannot be built
Details
ci/py3/ubuntu1804 The build of this commit was aborted
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.