Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove dead test #54040
From what I can tell, this test is no longer relevant. It was put in to
From what I can gather, there's no longer a good reason to run this
What does this PR do?
Fixes #53948 (by removing the affected test)
What issues does this PR fix or reference?
Test intermittently failed, not for any valid reason
Test is gone
Commits signed with GPG?
From what I can tell, this test is no longer relevant. It was put in to solve issue #2731, where Salt minions were checking DNS even when `--local` was passed. Now the code to check the DNS for the master has grown quite a bit more complex. In [salt/minion.py] if you simply force `check_dns = True` (i.e. remove the `local` check), this test will still pass running locally. If this test were effective at testing whether or not the CLI was going to timeout, it should fail - but it doesn't. From what I can gather, there's no longer a good reason to run this particular test. : https://github.com/saltstack/salt/blob/ffa70adec3ed5a1823976c7f32e37f165a9adb37/salt/minion.py#L138