Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixs integration terminate error #54050

Merged
merged 5 commits into from Jul 30, 2019

Conversation

@cmcmarrow
Copy link
Contributor

commented Jul 29, 2019

What does this PR do?

fixs integration terminate error

What issues does this PR fix or reference?

@dwoz requested the fix

Tests written?

No

Commits signed with GPG?

Yes

cmcmarrow added 2 commits Jul 29, 2019
cmcmarrow added 2 commits Jul 29, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 29, 2019

Codecov Report

Merging #54050 into 2019.2.1 will increase coverage by 26.65%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #54050       +/-   ##
=============================================
+ Coverage      9.83%   36.49%   +26.65%     
=============================================
  Files          1520     1576       +56     
  Lines        252633   269695    +17062     
  Branches      52482    56090     +3608     
=============================================
+ Hits          24840    98414    +73574     
+ Misses       226401   160082    -66319     
- Partials       1392    11199     +9807
Flag Coverage Δ
#arch ?
#debian8 36.49% <ø> (?)
#py2 36.49% <ø> (+26.65%) ⬆️
#zeromq 36.49% <ø> (+26.65%) ⬆️
Impacted Files Coverage Δ
salt/modules/pacmanpkg.py 25% <0%> (-9.66%) ⬇️
salt/modules/netaddress.py 52% <0%> (-4%) ⬇️
salt/modules/napalm_mod.py 30.58% <0%> (-0.69%) ⬇️
salt/modules/lxc.py 6.93% <0%> (ø) ⬆️
salt/modules/linux_ip.py 18% <0%> (ø) ⬆️
salt/modules/kerberos.py 14.95% <0%> (ø) ⬆️
salt/modules/scp_mod.py 30.5% <0%> (ø) ⬆️
salt/modules/aws_sqs.py 25.67% <0%> (ø) ⬆️
salt/returners/__init__.py 48.52% <0%> (ø)
salt/runners/__init__.py 100% <0%> (ø)
... and 1197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3bcd7...b3293a9. Read the comment docs.

@cmcmarrow

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

re-run full ubuntu

@cmcmarrow

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

re-run full ubuntu

@cmcmarrow cmcmarrow merged commit 4df6271 into saltstack:2019.2.1 Jul 30, 2019
24 checks passed
24 checks passed
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.