Conversation
ghost
removed their request for review
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Looks like there's a bunch of lint issues 😛
requirements/tests.txt
Outdated
| kubernetes<4.0 | ||
| psutil | ||
| pyvmomi | ||
| vSphere-Automation-SDK |
There was a problem hiding this comment.
This should instead be added to requirements/static/*.in as we talked about, likely where pyvmomi is also present, and then the requirements need to be recompiled, pre-commit run -av
There was a problem hiding this comment.
Yep, I'll get that going...
|
Changes are waiting on a response from this thread: vmware/vsphere-automation-sdk-python#38 |
…ion to util, added docstrings
and add required module to use new methods.
…ion to util, added docstrings
and add required module to use new methods.
… into new_tagging_vsphere_feature
Codecov Report
@@ Coverage Diff @@
## master #54058 +/- ##
=========================================
Coverage ? 24.89%
=========================================
Files ? 286
Lines ? 65762
Branches ? 14817
=========================================
Hits ? 16365
Misses ? 47366
Partials ? 2031
|
|
Windows tests are passing but the builds failed. |
8 participants
What does this PR do?
Adds tagging ability to vcenter proxy through new functions.
.
.
What issues does this PR fix or reference?
#52764
Tests written?
Yes
Commits signed with GPG?
Yes