Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tagging vsphere feature #54058

Merged
merged 60 commits into from Dec 19, 2019
Merged

Conversation

xeacott
Copy link
Contributor

@xeacott xeacott commented Jul 29, 2019

What does this PR do?

Adds tagging ability to vcenter proxy through new functions.
.
.

What issues does this PR fix or reference?

#52764

Tests written?

Yes

Commits signed with GPG?

Yes

@xeacott xeacott requested review from cro, cmcmarrow and Jul 29, 2019
@ghost ghost removed their request for review Jul 29, 2019
@xeacott xeacott requested a review from as a code owner Jul 29, 2019
@xeacott xeacott changed the base branch from develop to neon Jul 29, 2019
@xeacott xeacott changed the base branch from neon to develop Jul 29, 2019
waynew
waynew approved these changes Jul 29, 2019
Copy link
Contributor

@waynew waynew left a comment

Looks like there's a bunch of lint issues 😛

Copy link
Contributor

@cmcmarrow cmcmarrow left a comment

Nice work Joe!

@@ -20,6 +20,7 @@ supervisor; python_version < '3'
kubernetes<4.0
psutil
pyvmomi
vSphere-Automation-SDK
Copy link
Member

@s0undt3ch s0undt3ch Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should instead be added to requirements/static/*.in as we talked about, likely where pyvmomi is also present, and then the requirements need to be recompiled, pre-commit run -av

Copy link
Contributor Author

@xeacott xeacott Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll get that going...

cro
cro approved these changes Jul 30, 2019
@xeacott
Copy link
Contributor Author

@xeacott xeacott commented Aug 6, 2019

Changes are waiting on a response from this thread: vmware/vsphere-automation-sdk-python#38
@s0undt3ch this is the thread from which our previous conversation originates from - the outcome of this will determine the fate of the installation process :)

@codecov
Copy link

@codecov codecov bot commented Dec 16, 2019

Codecov Report

No coverage uploaded for pull request base (master@b564b22). Click here to learn what that means.
The diff coverage is 30.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #54058   +/-   ##
=========================================
  Coverage          ?   24.89%           
=========================================
  Files             ?      286           
  Lines             ?    65762           
  Branches          ?    14817           
=========================================
  Hits              ?    16365           
  Misses            ?    47366           
  Partials          ?     2031
Flag Coverage Δ
#centos7 23.72% <30.07%> (?)
#proxy 23.74% <30.07%> (?)
#py2 23.74% <30.07%> (?)
#py3 23.01% <30.07%> (?)
#runtests 23.74% <30.07%> (?)
#ubuntu1604 23.21% <30.07%> (?)
#zeromq 23.74% <30.07%> (?)
Impacted Files Coverage Δ
salt/proxy/vcenter.py 28.77% <0%> (ø)
salt/modules/vsphere.py 15.22% <29.6%> (ø)
salt/utils/vmware.py 8.47% <35.3%> (ø)

@dwoz
Copy link
Contributor

@dwoz dwoz commented Dec 19, 2019

Windows tests are passing but the builds failed.

@dwoz dwoz merged commit dc17032 into saltstack:master Dec 19, 2019
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants