Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point test-kitchen to my keepalive_maxcount branch #54180

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@dwoz
Copy link
Contributor

commented Aug 11, 2019

Use my test-kitchen branch for now so we can set the keepalive_maxcount setting on ssh connections.

Commits signed with GPG?

Yes

@dwoz dwoz force-pushed the dwoz:keepalive_maxcount branch from 492bb5e to 19a1f1b Aug 11, 2019
Copy link
Contributor

left a comment

Are we going to push these changes upstream? If so wheres the PR? Just want to make sure we are not always using someones personal fork.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@Ch3LL Yes, I created an upstream PR for this:

test-kitchen/test-kitchen#1582

I've also put a note in the Gemfile about what version we are waiting for.

@Ch3LL
Ch3LL approved these changes Aug 12, 2019
@dwoz dwoz merged commit 6fe6799 into saltstack:2019.2.1 Aug 12, 2019
8 of 24 checks passed
8 of 24 checks passed
ci/py2/debian9 This commit cannot be built
Details
ci/py2/amazon2 This commit is being built
Details
ci/py2/centos6 This commit is being built
Details
ci/py2/centos7 This commit is being built
Details
ci/py2/centos7/tcp This commit is being built
Details
ci/py2/fedora29 This commit is being built
Details
ci/py2/windows2016 This commit is being built
Details
ci/py3/amazon2 This commit is being built
Details
ci/py3/centos7 This commit is being built
Details
ci/py3/centos7/tcp This commit is being built
Details
ci/py3/debian9 This commit is being built
Details
ci/py3/fedora29 This commit is being built
Details
ci/py3/ubuntu1604 This commit is being built
Details
ci/py3/ubuntu1604/tcp This commit is being built
Details
ci/py3/ubuntu1804 This commit is being built
Details
ci/py3/windows2016 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.