Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Addition logging in testprogram used by integration.shell.test_minion.MinionTest.test_exit_status_correct_usage #54191

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@garethgreenaway
Copy link
Member

commented Aug 12, 2019

What does this PR do?

Adding some additional logging when the call to "proc_cmdline = proc.cmdline()" reults in a AccessDenied exception, so we can see what the process is and who the process is running as.

What issues does this PR fix or reference?

N/A

Previous Behavior

The test integration.shell.test_minion.MinionTest.test_exit_status_correct_usage occasionally fails on MacOS.

New Behavior

Adding some additional logging to see what process is cause the failure.

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
No. Attempting to fix a failing test.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…cmdline()" reults in a AccessDenied exception, so we can see what the process is and who the process is running as.
@dwoz
dwoz approved these changes Aug 12, 2019
@Ch3LL
Ch3LL approved these changes Aug 13, 2019
@waynew
waynew approved these changes Aug 13, 2019
@Akm0d
Akm0d approved these changes Aug 13, 2019
@dwoz dwoz merged commit a05018e into saltstack:2019.2.1 Aug 13, 2019
22 of 24 checks passed
22 of 24 checks passed
ci/py2/amazon2 This commit cannot be built
Details
ci/py3/centos7/tcp This commit cannot be built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.