Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal handling in subprocesses #54204

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@dwoz
Copy link
Contributor

commented Aug 13, 2019

What does this PR do?

Fix bugs in salt/utils/process.py caused by the use of multiprocessing.utils.register_after_fork

What issues does this PR fix or reference?

#54174

Tests written?

Yes

Commits signed with GPG?

Yes

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (2019.2.1@e5e9299). Click here to learn what that means.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##             2019.2.1   #54204   +/-   ##
===========================================
  Coverage            ?   37.14%           
===========================================
  Files               ?     1577           
  Lines               ?   270156           
  Branches            ?    57613           
===========================================
  Hits                ?   100341           
  Misses              ?   158514           
  Partials            ?    11301
Flag Coverage Δ
#amazon2 35.79% <82.35%> (?)
#debian8 35.58% <82.35%> (?)
#debian9 36.08% <82.35%> (?)
#fedora29 35.87% <82.35%> (?)
#py2 17.66% <41.17%> (?)
#py3 37.06% <82.35%> (?)
#tcp 35.99% <82.35%> (?)
#ubuntu1604 35.99% <82.35%> (?)
#windows2016 17.87% <41.17%> (?)
#zeromq 36.76% <82.35%> (?)
Impacted Files Coverage Δ
salt/utils/process.py 58.2% <82.35%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e9299...b40f41f. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (2019.2.1@e5e9299). Click here to learn what that means.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##             2019.2.1   #54204   +/-   ##
===========================================
  Coverage            ?   37.14%           
===========================================
  Files               ?     1577           
  Lines               ?   270156           
  Branches            ?    57613           
===========================================
  Hits                ?   100341           
  Misses              ?   158514           
  Partials            ?    11301
Flag Coverage Δ
#amazon2 35.79% <82.35%> (?)
#debian8 35.58% <82.35%> (?)
#debian9 36.08% <82.35%> (?)
#fedora29 35.87% <82.35%> (?)
#py2 17.66% <41.17%> (?)
#py3 37.06% <82.35%> (?)
#tcp 35.99% <82.35%> (?)
#ubuntu1604 35.99% <82.35%> (?)
#windows2016 17.87% <41.17%> (?)
#zeromq 36.76% <82.35%> (?)
Impacted Files Coverage Δ
salt/utils/process.py 58.2% <82.35%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e9299...b40f41f. Read the comment docs.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

This pertains to #54186

@Akm0d
Akm0d approved these changes Aug 15, 2019
@Akm0d
Akm0d approved these changes Aug 15, 2019
@Ch3LL
Ch3LL approved these changes Aug 15, 2019
@dwoz dwoz merged commit c5ee91c into saltstack:2019.2.1 Aug 16, 2019
1 check passed
1 check passed
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.