Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macOS homebrew cask support #54216

Merged
merged 13 commits into from Dec 24, 2019

Conversation

cdalvaro
Copy link
Contributor

@cdalvaro cdalvaro commented Aug 15, 2019

What does this PR do?

When listing Homebrew packages, cask packages do not have the right namespace when they are from a tap different from the default one.

This PR fixes this issue recovering the right namespace for each cask package.

Note: This PR comes from #53756

Previous Behavior

local:
----------
          ID: FiraCode Nerd Font
    Function: pkg.installed
        Name: homebrew/cask-fonts/font-firacode-nerd-font
      Result: False
     Comment: The following packages failed to install/update: homebrew/cask-fonts/font-firacode-nerd-font
     Started: 17:59:08.334054
    Duration: 14324.087 ms
     Changes:

New Behavior

local:
----------
          ID: FiraCode Nerd Font
    Function: pkg.installed
        Name: homebrew/cask-fonts/font-firacode-nerd-font
      Result: True
     Comment: All specified packages are already installed
     Started: 18:56:36.057920
    Duration: 48438.613 ms
     Changes:

Tests written?

Yes

Commits signed with GPG?

Yes

@cdalvaro cdalvaro requested a review from as a code owner Aug 15, 2019
@ghost ghost requested a review from xeacott Aug 15, 2019
@cdalvaro cdalvaro changed the title Improve macOS homebrew cask support 🚧 Improve macOS homebrew cask support Aug 15, 2019
@cdalvaro cdalvaro changed the title 🚧 Improve macOS homebrew cask support Improve macOS homebrew cask support Aug 15, 2019
@weswhet
Copy link
Collaborator

@weswhet weswhet commented Aug 15, 2019

I like this idea from the previous PR.

if name.startswith('caskroom/cask/'):
  salt.utils.versions.warn_until(
            'Neon',
            'The \'caskroom/cask/\' namespace for brew-cask packages'
            'is deprecated. Use \'homebrew/cask/\' instead.'
        )
  name = name.replace("caskroom/cask/", "homebrew/cask/")

@cdalvaro cdalvaro force-pushed the improve_macOS_homebrew_cask_support branch 2 times, most recently from 768ee44 to 4b0f4c0 Compare Aug 15, 2019
@weswhet
Copy link
Collaborator

@weswhet weswhet commented Aug 15, 2019

@eligundry any thoughts on this as you originally added support for casks?

@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Sep 1, 2019

@weswhet
Copy link
Collaborator

@weswhet weswhet commented Sep 1, 2019

LGTM.

xeacott
xeacott approved these changes Sep 5, 2019
@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Sep 30, 2019

Will this PR be merged?

@waynew
Copy link
Contributor

@waynew waynew commented Oct 4, 2019

Hey @cdalvaro - as you may have heard, we're changing to a single branch release strategy. What does that mean for this PR?

Well, you've got tests so 👍

We will be working to migrate all PRs from non-master branches to master. If you'd like to get your PR in sooner, please rebase it against master, force push to your branch, and edit this PR to be against master. If you need any help with any of those steps, please let us know!

@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Oct 5, 2019

Hey @cdalvaro - as you may have heard, we're changing to a single branch release strategy. What does that mean for this PR?

Well, you've got tests so 👍

We will be working to migrate all PRs from non-master branches to master. If you'd like to get your PR in sooner, please rebase it against master, force push to your branch, and edit this PR to be against master. If you need any help with any of those steps, please let us know!

I'll begin working on it!

@cdalvaro cdalvaro changed the base branch from 2019.2 to master Oct 5, 2019
@cdalvaro cdalvaro force-pushed the improve_macOS_homebrew_cask_support branch from ad9a37f to 1948b92 Compare Oct 5, 2019
@dwoz
Copy link
Contributor

@dwoz dwoz commented Oct 10, 2019

re-run full all

@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Oct 24, 2019

I would like to know if this PR will be finally merged

@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Nov 20, 2019

Please @xeacott, could you revise this PR, it was opened three months ago.

Thank you in advance.

dwoz
dwoz approved these changes Dec 17, 2019
Akm0d
Akm0d approved these changes Dec 17, 2019
@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Dec 24, 2019

All tests are OK now, please @xeacott, could you merge this PR??

Thank you in advance!

@dwoz dwoz merged commit 81cccd8 into saltstack:master Dec 24, 2019
49 checks passed
@weswhet
Copy link
Collaborator

@weswhet weswhet commented Dec 24, 2019

Thanks @dwoz 🚀

Happy holidays! 🎄

@cdalvaro
Copy link
Contributor Author

@cdalvaro cdalvaro commented Dec 24, 2019

Thank you very much @dwoz !!!

Happy holidays!

@cdalvaro cdalvaro deleted the improve_macOS_homebrew_cask_support branch Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants