Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test verify logs without a whole minion #54223

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@dwoz
Copy link
Contributor

commented Aug 15, 2019

What does this PR do?

Refactor and simplify tests that verify we don't create directories from schemes (eg file://foo/bar)

The test integration.shell.test_minion.MinionTest.test_issue_7754 is hanging on python 3.6. We don't need a whole minion to test such a small case so remove integration.shell.test_minion.MinionTest.test_issue_7754 and simplify how we are testing for the issue.

What issues does this PR fix or reference?

#7745

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.

Yes

Commits signed with GPG?

Yes

@waynew
waynew approved these changes Aug 15, 2019
@Ch3LL
Ch3LL approved these changes Aug 15, 2019
dwoz added 2 commits Aug 15, 2019
@dwoz dwoz merged commit 99a8fc5 into saltstack:2019.2.1 Aug 16, 2019
3 of 24 checks passed
3 of 24 checks passed
ci/py2/amazon2 This commit is being built
Details
ci/py2/centos6 This commit is being built
Details
ci/py2/centos7 This commit is being built
Details
ci/py2/centos7/tcp This commit is being built
Details
ci/py2/debian8 This commit is being built
Details
ci/py2/debian9 This commit is being built
Details
ci/py2/fedora29 This commit is being built
Details
ci/py2/ubuntu1604 This commit is being built
Details
ci/py2/ubuntu1604/tcp This commit is being built
Details
ci/py2/ubuntu1804 This commit is being built
Details
ci/py2/windows2016 This commit is being built
Details
ci/py3/amazon2 This commit is being built
Details
ci/py3/centos7 This commit is being built
Details
ci/py3/centos7/tcp This commit is being built
Details
ci/py3/debian8 This commit is being built
Details
ci/py3/debian9 This commit is being built
Details
ci/py3/fedora29 This commit is being built
Details
ci/py3/ubuntu1604 This commit is being built
Details
ci/py3/ubuntu1604/tcp This commit is being built
Details
ci/py3/ubuntu1804 This commit is being built
Details
ci/py3/windows2016 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
dwoz added a commit that referenced this pull request Sep 20, 2019
Backport #54223 into 2018.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.