Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit utils jinja when run on their own #54264

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@dwoz
Copy link
Contributor

commented Aug 20, 2019

What does this PR do?

Fix an issue to make sure unit.utils.test_jinja tests will pass when they are run on their own

Tests written?

No - Fixing unit tests

Commits signed with GPG?

Yes

Copy link
Member

left a comment

This suggests a bigger problem.
Ie, if this addition makes tests pass when they run on their own, what "fills in" the missing options when they run with the rest of the test suite.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

This suggests a bigger problem.
Ie, if this addition makes tests pass when they run on their own, what "fills in" the missing options when they run with the rest of the test suite.

That's definitely an issue. I've created a ticket (#54265) to go back and figure out how this is getting set.

@Ch3LL
Ch3LL approved these changes Aug 21, 2019
@Akm0d
Akm0d approved these changes Aug 21, 2019
@dwoz dwoz merged commit b3c70c3 into saltstack:2019.2.1 Aug 21, 2019
21 of 24 checks passed
21 of 24 checks passed
ci/py2/windows2016 This commit cannot be built
Details
ci/py3/centos7 The build of this commit was aborted
Details
ci/py3/windows2016 This commit cannot be built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.