devinfo: Add new module devinfo #54267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Just took a glance at this and it seems reasonable. Does it relate at all to salt/modules/udev.py ? |
I was hoping to use this module as a basis to discover hardware. Some functions are using udev, but the main one is using hwinfo. |
|
Rebased on top of master |
aplanas
force-pushed
the
fix_devinfo
branch
2 times, most recently
from
3e1d4e1
to
8e5b7ff
Compare
aplanas
force-pushed
the
fix_devinfo
branch
3 times, most recently
from
877bb9a
to
bfbf92d
Compare
aplanas
force-pushed
the
fix_devinfo
branch
4 times, most recently
from
e029c5b
to
5641e87
Compare
devinfo is a new module designed to get hardware information. It provides and API to access the output of hwinfo, and a set of functions to filter udev information.
|
no failing test, re-review? |
dwoz
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
devinfo is a new module designed to get hardware information. It
provides and API to access the output of hwinfo, and a set of functions
to filter udev information.
Tests written?
Yes