Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#53931 never fail on codecov curls #54274

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@felippeb
Copy link
Contributor

commented Aug 21, 2019

What does this PR do?

adds || true to codecov curls so we don't fail if they are down.

What issues does this PR fix or reference?

#53931

Previous Behavior

codecov curl statements could cause a test run to fail if codecov is down

New Behavior

bash will now return 0 for this curl even if codecov is down

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@felippeb felippeb requested a review from saltstack/team-core as a code owner Aug 21, 2019
@pull-assigner pull-assigner bot requested a review from Akm0d Aug 21, 2019
@dwoz
dwoz approved these changes Aug 21, 2019
@waynew
waynew approved these changes Aug 21, 2019
@Akm0d
Akm0d approved these changes Aug 21, 2019
@dwoz dwoz merged commit 2c4afa0 into saltstack:2019.2.1 Aug 21, 2019
3 of 24 checks passed
3 of 24 checks passed
ci/py2/amazon2 This commit is being built
Details
ci/py2/centos6 This commit is being built
Details
ci/py2/centos7 This commit is being built
Details
ci/py2/centos7/tcp This commit is being built
Details
ci/py2/debian8 This commit is being built
Details
ci/py2/debian9 This commit is being built
Details
ci/py2/fedora29 This commit is being built
Details
ci/py2/ubuntu1604 This commit is being built
Details
ci/py2/ubuntu1604/tcp This commit is being built
Details
ci/py2/ubuntu1804 This commit is being built
Details
ci/py2/windows2016 This commit is being built
Details
ci/py3/amazon2 This commit is being built
Details
ci/py3/centos7 This commit is being built
Details
ci/py3/centos7/tcp This commit is being built
Details
ci/py3/debian8 This commit is being built
Details
ci/py3/debian9 This commit is being built
Details
ci/py3/fedora29 This commit is being built
Details
ci/py3/ubuntu1604 This commit is being built
Details
ci/py3/ubuntu1604/tcp This commit is being built
Details
ci/py3/ubuntu1804 This commit is being built
Details
ci/py3/windows2016 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.