Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wart in test_process tests on windows #54305

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@dwoz
Copy link
Contributor

commented Aug 25, 2019

Tests written?

No - Fixing broken tests on windows

Commits signed with GPG?

Yes

@twangboy

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

Is the new test_win_functions failure related?

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Is the new test_win_functions failure related?

I'm not sure how it would be, I re-started the test run to see if it's just a flaky test or not.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@waynew
waynew approved these changes Aug 26, 2019
@dwoz dwoz merged commit 71fb051 into saltstack:2019.2.1 Aug 26, 2019
22 of 24 checks passed
22 of 24 checks passed
ci/py2/centos6 This commit cannot be built
Details
ci/py2/windows2016 This commit cannot be built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.