Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Do not raise the exception in testprogram.py #54314

Conversation

@garethgreenaway
Copy link
Member

commented Aug 26, 2019

What does this PR do?

Do not raise the exception if a process can not be access, just continue

What issues does this PR fix or reference?

N/A

Previous Behavior

If we receive an AccessDenied exception when looking for zombie processes the exception is raseid.

New Behavior

If we receive an AccessDenied exception when looking for zombie processes just continue.

Tests written?

No. Updating existing tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Aug 26, 2019
@pull-assigner pull-assigner bot requested review from waynew and removed request for saltstack/team-core Aug 26, 2019
@dwoz
dwoz approved these changes Aug 26, 2019
@waynew
waynew approved these changes Aug 26, 2019
@Akm0d
Akm0d approved these changes Aug 26, 2019
@dwoz dwoz merged commit 9334e4e into saltstack:2019.2.1 Aug 26, 2019
21 of 24 checks passed
21 of 24 checks passed
ci/py2/ubuntu1604/tcp This commit cannot be built
Details
ci/py2/windows2016 This commit cannot be built
Details
ci/py3/windows2016 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.