Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Catch the AccessDenied exception and continue when running under Py3. #54327

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@garethgreenaway
Copy link
Member

commented Aug 27, 2019

What does this PR do?

Catch the AccessDenied exception and continue when running under Py3.

What issues does this PR fix or reference?

N/A

Previous Behavior

Same behavior we saw under Python2 happening under Python3 because of different code for Python3.

New Behavior

Catch the AccessDenied exception and continue.

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Aug 27, 2019
@pull-assigner pull-assigner bot requested review from xeacott and removed request for saltstack/team-core Aug 27, 2019
@Akm0d
Akm0d approved these changes Aug 27, 2019
@dwoz dwoz merged commit 490ee69 into saltstack:2019.2.1 Aug 29, 2019
22 of 24 checks passed
22 of 24 checks passed
ci/py2/ubuntu1604/tcp This commit cannot be built
Details
ci/py2/windows2016 This commit cannot be built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.