Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit.utils.test_win_dacl (2019.2.1) #54386

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@twangboy
Copy link
Contributor

commented Sep 3, 2019

What does this PR do?

Fixes a failing test. The test was failing because the list of permissions isn't always in the same order. This adds a .sort() so that the permissions come back sorted.

What issues does this PR fix or reference?

jenkins

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz
dwoz approved these changes Sep 3, 2019
@Akm0d
Akm0d approved these changes Sep 3, 2019
@dwoz dwoz merged commit 5161203 into saltstack:2019.2.1 Sep 3, 2019
3 of 24 checks passed
3 of 24 checks passed
ci/py2/amazon2 This commit is being built
Details
ci/py2/centos6 This commit is being built
Details
ci/py2/centos7 This commit is being built
Details
ci/py2/centos7/tcp This commit is being built
Details
ci/py2/debian8 This commit is being built
Details
ci/py2/debian9 This commit is being built
Details
ci/py2/fedora29 This commit is being built
Details
ci/py2/ubuntu1604 This commit is being built
Details
ci/py2/ubuntu1604/tcp This commit is being built
Details
ci/py2/ubuntu1804 This commit is being built
Details
ci/py2/windows2016 This commit is being built
Details
ci/py3/amazon2 This commit is being built
Details
ci/py3/centos7 This commit is being built
Details
ci/py3/centos7/tcp This commit is being built
Details
ci/py3/debian8 This commit is being built
Details
ci/py3/debian9 This commit is being built
Details
ci/py3/fedora29 This commit is being built
Details
ci/py3/ubuntu1604 This commit is being built
Details
ci/py3/ubuntu1604/tcp This commit is being built
Details
ci/py3/ubuntu1804 This commit is being built
Details
ci/py3/windows2016 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.