Tencent Cloud 201921 by Akm0d · Pull Request #54526 · saltstack/salt

Akm0d · 2019-09-18T22:22:34Z

What does this PR do?

Merge #54518 into 2019.2.1

likexian · 2019-10-18T04:38:41Z

Hello @Akm0d
Is there anything I can help?

Akm0d · 2019-10-18T18:15:38Z

@likexian we're just waiting for the unrelated test failures to pass or for approval from core

likexian · 2019-11-18T02:59:44Z

Hello,
The failed CI seems not the responsibility of this PR's code.
Can someone please have a review? it take too long to process.

Akm0d · 2019-12-02T20:52:34Z

10:48:08  /var/jenkins/workspace/pr-docs_PR-54526/doc/ref/clouds/all/salt.cloud.clouds.tencentcloud.rst:document isn't included in any toctree```

likexian · 2020-01-02T08:35:41Z

@Akm0d This PR takes so long, what can I do for it?

…tcloud_201921

Akm0d · 2020-01-04T06:07:22Z

@Akm0d This PR takes so long, what can I do for it?

I'm sorry this has taken so long :/ We just need all the tests passing.

…tcloud_201921

codecov · 2020-01-04T19:05:35Z

Codecov Report

Merging #54526 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #54526      +/-   ##
==========================================
+ Coverage   18.78%   18.78%   +0.01%     
==========================================
  Files         825      825              
  Lines      175895   175895              
  Branches    37838    37838              
==========================================
+ Hits        33028    33030       +2     
+ Misses     140192   140191       -1     
+ Partials     2675     2674       -1

Flag	Coverage Δ
#archlts	`18.06% <ø> (+0.01%)`	⬆️
#centos7	`23.73% <ø> (+0.01%)`	⬆️
#proxy	`23.76% <ø> (ø)`	⬆️
#py2	`18.58% <ø> (ø)`	⬆️
#py3	`18.41% <ø> (+0.01%)`	⬆️
#runtests	`18.78% <ø> (+0.01%)`	⬆️
#ubuntu1604	`23.7% <ø> (ø)`	⬇️
#zeromq	`18.78% <ø> (+0.01%)`	⬆️

Impacted Files	Coverage Δ
salt/transport/ipc.py	`44.93% <0%> (-0.57%)`	⬇️
salt/config/__init__.py	`27.63% <0%> (+0.18%)`	⬆️
salt/utils/event.py	`38.67% <0%> (+0.31%)`	⬆️

codecov · 2020-01-04T19:05:41Z

Codecov Report

❗ No coverage uploaded for pull request base (master@8e529ca). Click here to learn what that means.
The diff coverage is 11.77%.

@@            Coverage Diff            @@
##             master   #54526   +/-   ##
=========================================
  Coverage          ?   18.78%           
=========================================
  Files             ?      825           
  Lines             ?   175895           
  Branches          ?    37838           
=========================================
  Hits              ?    33030           
  Misses            ?   140191           
  Partials          ?     2674

Flag	Coverage Δ
#archlts	`18.06% <11.77%> (?)`
#centos7	`23.73% <0%> (?)`
#proxy	`23.76% <0%> (?)`
#py2	`18.58% <11.77%> (?)`
#py3	`18.41% <11.77%> (?)`
#runtests	`18.78% <11.77%> (?)`
#ubuntu1604	`23.7% <0%> (?)`
#zeromq	`18.78% <11.77%> (?)`

Impacted Files	Coverage Δ
salt/master.py	`14.93% <ø> (ø)`
salt/utils/win_functions.py	`21.37% <0%> (ø)`
salt/modules/systemd_service.py	`15.11% <12.5%> (ø)`

Akm0d · 2020-01-07T04:44:42Z

re-run full amazon1

waynew · 2020-01-07T17:51:37Z

FWIW, it seems like py2/amazon1 might be/have been pre-deprecated by Amazon.

Akm0d · 2020-01-08T16:57:35Z

re-run full amazon1

likexian · 2020-01-09T01:59:52Z

@Akm0d You are my hero!
It so difficult to make all tests pass. Thanks so much for your works.

garethgreenaway approved these changes Sep 19, 2019

View reviewed changes

Akm0d commented Sep 19, 2019

View reviewed changes

Comment thread tests/integration/files/conf/cloud.profiles.d/tencentcloud.conf Outdated

waynew suggested changes Sep 19, 2019

View reviewed changes

Comment thread doc/topics/cloud/tencentcloud.rst Outdated

Comment thread tests/unit/test_config.py Outdated

Comment thread tests/unit/test_config.py Outdated

Comment thread tests/unit/test_config.py Outdated

Comment thread tests/unit/test_config.py Outdated

waynew reviewed Sep 19, 2019

View reviewed changes