Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Porting #49837 to master #54552

Merged
merged 16 commits into from
Apr 29, 2020

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 18, 2019

Porting #49837 to master

@garethgreenaway garethgreenaway requested a review from a team September 18, 2019 23:44
@ghost ghost requested review from DmitryKuzmenko and removed request for a team September 18, 2019 23:44
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #49837 to 2019.2.1 [master] Porting #49837 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:57
@waynew waynew added this to PR needs merge to master in PRs to port to master Oct 17, 2019
dwoz
dwoz previously approved these changes Oct 22, 2019
@dwoz
Copy link
Contributor

dwoz commented Oct 22, 2019

re-run full all

@dwoz dwoz requested a review from a team as a code owner October 28, 2019 17:16
dhiltonp
dhiltonp previously approved these changes Nov 7, 2019
@yuriks
Copy link

yuriks commented Apr 3, 2020

Is there anything blocking this change? This would be really useful to have available.

salt/states/file.py Outdated Show resolved Hide resolved
salt/states/file.py Outdated Show resolved Hide resolved
@mchugh19
Copy link
Contributor

@garethgreenaway are you able to fix up the doc strings? Or should I duplicate the PR to fix it up?

Fixing versionchanged
@garethgreenaway
Copy link
Contributor Author

@mchugh19 Thanks for the ping, the versionchanged strings have been updated.

@dwoz dwoz merged commit 7c37be4 into saltstack:master Apr 29, 2020
PRs to port to master automation moved this from PR needs merge to master to PR merged Apr 29, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to In progress in Sodium via automation May 18, 2020
@sagetherage sagetherage moved this from In progress to Done in Sodium May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants