Skip to content

[master] Porting #49837 to master#54552

Merged
dwoz merged 16 commits intosaltstack:masterfrom
garethgreenaway:2019_2_1_port_49837
Apr 29, 2020
Merged

[master] Porting #49837 to master#54552
dwoz merged 16 commits intosaltstack:masterfrom
garethgreenaway:2019_2_1_port_49837

Conversation

@garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 18, 2019

Porting #49837 to master

@garethgreenaway garethgreenaway requested a review from a team September 18, 2019 23:44
@ghost ghost requested review from DmitryKuzmenko and removed request for a team September 18, 2019 23:44
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #49837 to 2019.2.1 [master] Porting #49837 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:57
dwoz
dwoz previously approved these changes Oct 22, 2019
@dwoz
Copy link
Contributor

dwoz commented Oct 22, 2019

re-run full all

@dwoz dwoz requested a review from a team as a code owner October 28, 2019 17:16
dhiltonp
dhiltonp previously approved these changes Nov 7, 2019
@yuriks
Copy link

yuriks commented Apr 3, 2020

Is there anything blocking this change? This would be really useful to have available.

@mchugh19
Copy link
Contributor

@garethgreenaway are you able to fix up the doc strings? Or should I duplicate the PR to fix it up?

@garethgreenaway garethgreenaway dismissed stale reviews from dhiltonp and dwoz via 0118965 April 26, 2020 22:34
Fixing versionchanged
@garethgreenaway
Copy link
Contributor Author

@mchugh19 Thanks for the ping, the versionchanged strings have been updated.

@dwoz dwoz merged commit 7c37be4 into saltstack:master Apr 29, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants