Skip to content

[master] Porting #50083 to master - #54632

Merged
dwoz merged 4 commits into
saltstack:masterfrom
garethgreenaway:2019_2_1_port_50083
Jan 2, 2020
Merged

[master] Porting #50083 to master#54632
dwoz merged 4 commits into
saltstack:masterfrom
garethgreenaway:2019_2_1_port_50083

Conversation

@garethgreenaway

@garethgreenaway garethgreenaway commented Sep 19, 2019

Copy link
Copy Markdown
Contributor

Porting #50083 to master

@garethgreenaway
garethgreenaway requested a review from a team September 19, 2019 00:44
@ghost
ghost requested review from DmitryKuzmenko and removed request for a team September 19, 2019 00:44
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #50083 to 2019.2.1 [master] Porting #50083 to master Sep 24, 2019
@garethgreenaway
garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:42
@codecov

codecov Bot commented Sep 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #54632 into master will increase coverage by 2.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #54632       +/-   ##
===========================================
+ Coverage   15.08%   17.65%    +2.57%     
===========================================
  Files        1577      612      -965     
  Lines      270239    99401   -170838     
  Branches    57591    22773    -34818     
===========================================
- Hits        40761    17549    -23212     
+ Misses     225611    79703   -145908     
+ Partials     3867     2149     -1718
Flag Coverage Δ
#archlts ?
#centos7 ?
#debian8 ?
#py2 ?
#py3 17.65% <ø> (+4.42%) ⬆️
#ubuntu1604 ?
#windows2016 17.65% <ø> (?)
#zeromq 17.65% <ø> (+4.12%) ⬆️
Impacted Files Coverage Δ
salt/executors/__init__.py 0% <0%> (-100%) ⬇️
salt/renderers/__init__.py 0% <0%> (-100%) ⬇️
salt/tops/__init__.py 0% <0%> (-100%) ⬇️
salt/sdb/__init__.py 0% <0%> (-100%) ⬇️
salt/tokens/__init__.py 0% <0%> (-100%) ⬇️
salt/utils/aws.py 0% <0%> (-43.22%) ⬇️
salt/utils/openstack/pyrax/authenticate.py 0% <0%> (-41.67%) ⬇️
salt/utils/xmlutil.py 13.63% <0%> (-40.91%) ⬇️
salt/utils/smb.py 19.83% <0%> (-39.68%) ⬇️
salt/utils/stringio.py 47.61% <0%> (-33.34%) ⬇️
... and 1458 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b86bf...c4aa247. Read the comment docs.

@garethgreenaway
garethgreenaway requested a review from a team as a code owner December 3, 2019 18:49
@dwoz
dwoz merged commit c90447f into saltstack:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants