Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Porting #51498 to master #54652

Merged
merged 6 commits into from
Mar 17, 2022

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 19, 2019

Porting #51498 to master

@garethgreenaway garethgreenaway requested a review from a team September 19, 2019 00:58
@ghost ghost requested review from twangboy and removed request for a team September 19, 2019 00:58
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #51498 to 2019.2.1 [master] Porting #51498 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:38
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs testcase. will look into getting this added

@Ch3LL Ch3LL added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Dec 3, 2019
@garethgreenaway garethgreenaway requested a review from a team as a code owner January 14, 2020 21:02
@Ch3LL Ch3LL removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jan 14, 2020
twangboy
twangboy previously approved these changes Mar 10, 2020
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Mar 9, 2022
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.76s
- exit code: 1

The function 'vpc_peering_connection_absent' on 'salt/states/boto_vpc.py' does not have a docstring
Found 1 errors


Thanks again!

@Ch3LL Ch3LL merged commit 2c2b9f7 into saltstack:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master-port Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants