Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minion's remove_periodic_callback() #54777

Merged
merged 5 commits into from Sep 29, 2019
Merged

Conversation

@javierbertoli
Copy link
Contributor

@javierbertoli javierbertoli commented Sep 26, 2019

What does this PR do?

Fixes a typo in the function name and the number of parameters being passed.

What issues does this PR fix or reference?

It should fix #54776

Tests written?

Yes (thanks @waynew !!)

Commits signed with GPG?

No

@javierbertoli javierbertoli requested a review from as a code owner Sep 26, 2019
@pull-assigner pull-assigner bot requested a review from Akm0d Sep 26, 2019
@bryceml
Copy link
Contributor

@bryceml bryceml commented Sep 26, 2019

I re-ran the lint job with nox using py3

@bryceml
Copy link
Contributor

@bryceml bryceml commented Sep 26, 2019

I opened a pr to this fork with the way I ran the lint job.

dwoz
dwoz approved these changes Sep 29, 2019
@codecov
Copy link

@codecov codecov bot commented Sep 29, 2019

Codecov Report

No coverage uploaded for pull request base (2019.2.1@83f8f5c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             2019.2.1   #54777   +/-   ##
===========================================
  Coverage            ?   37.33%           
===========================================
  Files               ?     1577           
  Lines               ?   270144           
  Branches            ?    57608           
===========================================
  Hits                ?   100860           
  Misses              ?   157975           
  Partials            ?    11309
Flag Coverage Δ
#amazon2 36.34% <100%> (?)
#centos7 36.25% <100%> (?)
#py2 37% <100%> (?)
#py3 36.25% <100%> (?)
#tcp 36.8% <100%> (?)
#ubuntu1604 36.8% <100%> (?)
#zeromq 37.09% <100%> (?)
Impacted Files Coverage Δ
salt/minion.py 35.15% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f8f5c...459c790. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Sep 29, 2019

Codecov Report

No coverage uploaded for pull request base (2019.2.1@83f8f5c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             2019.2.1   #54777   +/-   ##
===========================================
  Coverage            ?   37.33%           
===========================================
  Files               ?     1577           
  Lines               ?   270144           
  Branches            ?    57608           
===========================================
  Hits                ?   100860           
  Misses              ?   157975           
  Partials            ?    11309
Flag Coverage Δ
#amazon2 36.34% <100%> (?)
#centos7 36.25% <100%> (?)
#py2 37% <100%> (?)
#py3 36.25% <100%> (?)
#tcp 36.8% <100%> (?)
#ubuntu1604 36.8% <100%> (?)
#zeromq 37.09% <100%> (?)
Impacted Files Coverage Δ
salt/minion.py 35.15% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f8f5c...459c790. Read the comment docs.

@dwoz dwoz merged commit 4c240e5 into saltstack:2019.2.1 Sep 29, 2019
2 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants