Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure metaproxy directory is included in sdist #54783

Conversation

@garethgreenaway
Copy link
Member

garethgreenaway commented Sep 26, 2019

What does this PR do?

Adding init.py to metaproxy directory so that metaproxy is included when running setup.py.

What issues does this PR fix or reference?

#54751

Previous Behavior

The metaproxy directory was not being included when running setup.py

New Behavior

The metaproxy directory is now being included when running setup.py

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…ed when running setup.py.
@Ch3LL
Ch3LL approved these changes Sep 26, 2019
@waynew
waynew approved these changes Sep 26, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

dwoz commented Sep 29, 2019

This change has a test in the package tests.

@dwoz dwoz merged commit 6b43fbe into saltstack:2019.2.1 Sep 29, 2019
21 of 24 checks passed
21 of 24 checks passed
ci/py2/centos6 This commit is being built
Details
ci/py3/centos7/tcp This commit is being built
Details
ci/py3/windows2016 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.