Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dns_check to return uri-compatible ipv6 addresses, add tests #54784

Merged
merged 4 commits into from Sep 28, 2019

Conversation

@dhiltonp
Copy link
Contributor

dhiltonp commented Sep 26, 2019

What does this PR do?

dns_check returns ipv6 addresses in uri-compatible format, simplifies logic, adds tests

What issues does this PR fix or reference?

Resolves #54762, adds tests.

Tests written?

Yes

Commits signed with GPG?

Yes

@waynew
waynew approved these changes Sep 26, 2019
@dhiltonp dhiltonp force-pushed the dhiltonp:ipv46 branch from 058d83b to ebd940e Sep 26, 2019
@dhiltonp dhiltonp changed the title re-fix dns_check to return uri-compatible ipv6 addresses, add tests fix dns_check to return uri-compatible ipv6 addresses, add tests Sep 26, 2019
@dhiltonp dhiltonp force-pushed the dhiltonp:ipv46 branch from 44e65b7 to 1774ac1 Sep 27, 2019
dhiltonp added 2 commits Sep 26, 2019
@dhiltonp dhiltonp force-pushed the dhiltonp:ipv46 branch from 1774ac1 to 93ebd09 Sep 27, 2019
@dhiltonp dhiltonp changed the base branch from master to 2019.2.1 Sep 27, 2019
dhiltonp added 2 commits Sep 27, 2019
@dhiltonp dhiltonp merged commit 7912b67 into saltstack:2019.2.1 Sep 28, 2019
24 checks passed
24 checks passed
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.