Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Batch with failhard fix #54806

Merged
merged 3 commits into from Oct 1, 2019

Conversation

@Oloremo
Copy link
Contributor

Oloremo commented Sep 29, 2019

What does this PR do?

Added proper detection of failhard during the orchestration\cli batch logic.

This is backport of the #54700, huge thanks to @mattp- for the original patch.

What issues does this PR fix or reference?

#54521

Previous Behavior

batch didn't stop upon encountering the error with failhard set to True

New Behavior

batch stops upon encountering the error with failhard set to True

Tests written?

Yes

Commits signed with GPG?

Yes

Oloremo added 2 commits Sep 29, 2019
@Oloremo Oloremo requested a review from saltstack/team-core as a code owner Sep 29, 2019
@pull-assigner pull-assigner bot requested a review from twangboy Sep 29, 2019
@dwoz
dwoz approved these changes Oct 1, 2019
@dwoz dwoz merged commit 433b6fa into saltstack:2019.2.1 Oct 1, 2019
24 checks passed
24 checks passed
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.