Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip state pip >=10.0 and <=18.0 #54807

Merged
merged 3 commits into from Sep 30, 2019

Conversation

@dwoz
Copy link
Contributor

dwoz commented Sep 29, 2019

This PR takes the work from #54772 and adds tests

What does this PR do?

When using pip versions between 10.0 and 18.0, the import of the pip.exceptions modules in pip_state will fail, as it was moved to pip._internal.exceptions in pip version 10.0.

Ref pip 10.0.0b1 release notes:
https://pip.pypa.io/en/stable/news/#b1-2018-03-31

What issues does this PR fix or reference?

#54762

Previous Behavior

pip.installed state will fail to load with pip >=10.0 and <=18.0

New Behavior

pip.installed state will load with pip >=10.0 and <=18.0

Tests written?

Yes

Commits signed with GPG?

Yes

when using pip versions between 10.0 and 18.1, the import of the _internal modules in pip_state will fail.

Ref pip 10.0.0b1 release notes:
https://pip.pypa.io/en/stable/news/#b1-2018-03-31

This PR changes 18.1 to 10.0
Revert change for pip._internal.req.constructors version query.
@dwoz dwoz referenced this pull request Sep 29, 2019
@dwoz dwoz changed the title Patch 2 Fix pip state pip >=10.0 and <=18.0 Sep 29, 2019
@dwoz dwoz force-pushed the dwoz:patch-2 branch from 79463f6 to 664806b Sep 30, 2019
@dwoz dwoz merged commit b61b30d into saltstack:2019.2.1 Sep 30, 2019
22 of 24 checks passed
22 of 24 checks passed
ci/py2/centos6 This commit cannot be built
Details
ci/py3/windows2016 The build of this commit was aborted
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.