-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix issue 54755 and add regression tests #54826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
re-run full all |
1 similar comment
|
re-run full all |
Codecov Report
@@ Coverage Diff @@
## 2019.2.1 #54826 +/- ##
=============================================
+ Coverage 5.02% 36.77% +31.74%
=============================================
Files 1521 1577 +56
Lines 253244 269866 +16622
Branches 54002 56108 +2106
=============================================
+ Hits 12734 99238 +86504
+ Misses 239072 159279 -79793
- Partials 1438 11349 +9911
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 2019.2.1 #54826 +/- ##
=============================================
+ Coverage 5.02% 36.77% +31.74%
=============================================
Files 1521 1577 +56
Lines 253244 269866 +16622
Branches 54002 56108 +2106
=============================================
+ Hits 12734 99238 +86504
+ Misses 239072 159279 -79793
- Partials 1438 11349 +9911
Continue to review full report at Codecov.
|
What does this PR do?
Address #54755 and add regression tests.
In general we should try to address this kind of thing without mucking around with already imported modules. Ideally we'd recognize that pip was upgraded and re-start the minion automatically. This will however address the bugs reported against the pip_state and other states using the
unlessrequisite.What issues does this PR fix or reference?
#54755
Previous Behavior
If no pip module is in the python environment imports of the pip state failed with multiple tracebacks. This is due to us trying to
del pipwhen there is nopipvariable defined.New Behavior
Use a
purge_pipmethod before trying to importpipthis method will only try to remove thepipmodule and/orpipvariable if it exists.Tests written?
Yes
Commits signed with GPG?
Yes