Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] Fix global disabling code in scheduler #54828

Conversation

@garethgreenaway
Copy link
Member

garethgreenaway commented Sep 30, 2019

What does this PR do?

Rework code that handles individual jobs being disabled and scheduler being globally being disabled.

What issues does this PR fix or reference?

#54820

Previous Behavior

Previously disabling the schedule would result in individual jobs being disabled when they were run through eval.

New Behavior

This change does not change schedule items.

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes. Existing tests updated.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

… being globally being disabled. Previously disabling the schedule would result in individual jobs being disabled when they were run through eval. This change does not change schedule items.
@garethgreenaway garethgreenaway requested review from waynew and dwoz Sep 30, 2019
@Akm0d
Akm0d approved these changes Sep 30, 2019
@dwoz dwoz merged commit ed94aa5 into saltstack:2019.2.1 Oct 1, 2019
22 of 24 checks passed
22 of 24 checks passed
ci/py2/centos6 This commit is being built
Details
ci/py3/ubuntu1804 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
@dwoz
dwoz approved these changes Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.