Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix to git state module when calling git.config_get_regexp #54844

Conversation

@garethgreenaway
Copy link
Member

garethgreenaway commented Oct 2, 2019

What does this PR do?

When calling git.config_get_regexp to check for filter.lfs. in git config, if the option is not available this would result with a return code of 1 which would result in an error being logged. Since one possible result is that the configuration would not be there, we ignore the return code.

What issues does this PR fix or reference?

#54817

Previous Behavior

Error in logs when calling git.config_get_regexp

New Behavior

No error in log

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…config, if the option is not available this would result with a return code of 1 which would result in an error being logged. Since one possible result is that the configuration would not be there, we ignore the return code.
@dwoz dwoz changed the base branch from 2019.2.1 to master Oct 13, 2019
@waynew
waynew approved these changes Oct 14, 2019
@garethgreenaway garethgreenaway changed the title [2019.2.1] Fix to git state module when calling git.config_get_regexp [master] Fix to git state module when calling git.config_get_regexp Oct 14, 2019
@garethgreenaway garethgreenaway changed the base branch from master to 2019.2.1 Oct 14, 2019
@dwoz
dwoz approved these changes Oct 14, 2019
@Akm0d
Akm0d approved these changes Oct 14, 2019
@dwoz dwoz merged commit 52fee6f into saltstack:2019.2.1 Oct 14, 2019
3 of 24 checks passed
3 of 24 checks passed
ci/py3/windows2016 Something is wrong with the build of this commit
Details
ci/py2/amazon2 This commit is being built
Details
ci/py2/centos6 This commit is being built
Details
ci/py2/centos7 This commit is being built
Details
ci/py2/centos7/tcp This commit is being built
Details
ci/py2/debian8 This commit is being built
Details
ci/py2/debian9 This commit is being built
Details
ci/py2/fedora29 This commit is being built
Details
ci/py2/ubuntu1604 This commit is being built
Details
ci/py2/ubuntu1604/tcp This commit is being built
Details
ci/py2/ubuntu1804 This commit is being built
Details
ci/py2/windows2016 This commit is being built
Details
ci/py3/amazon2 This commit is being built
Details
ci/py3/centos7 This commit is being built
Details
ci/py3/centos7/tcp This commit is being built
Details
ci/py3/debian8 This commit is being built
Details
ci/py3/debian9 This commit is being built
Details
ci/py3/fedora29 This commit is being built
Details
ci/py3/ubuntu1604 This commit is being built
Details
ci/py3/ubuntu1604/tcp This commit is being built
Details
ci/py3/ubuntu1804 This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.