Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding multipart/form-data file posting to http.query util #54903

Merged

Conversation

nicholasmhughes
Copy link
Member

@nicholasmhughes nicholasmhughes commented Oct 5, 2019

What does this PR do?

This PR adds the ability for the requests backend to post files as multipart/form-data. I'm not really familiar with tornado, or else I'd add that too... updates welcome!

What issues does this PR fix or reference?

N/A

Previous Behavior

The http.query utility could not handle multipart/form-data, which is commonly used in file uploads to web servers.

New Behavior

Now the http.query utility supports that capability in the requests backend.

Tests written?

Yes

Commits signed with GPG?

Yes

salt/utils/http.py Outdated Show resolved Hide resolved
@nicholasmhughes nicholasmhughes requested a review from as a code owner Dec 6, 2019
@ghost ghost requested a review from Ch3LL Dec 6, 2019
dwoz
dwoz approved these changes Dec 9, 2019
@dwoz dwoz merged commit 0b5d3c6 into saltstack:master Dec 9, 2019
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants