Added request_interval feature to wait_for_successful_query module #54916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Oloremo
force-pushed
the
added_http_request_interval
branch
from
26d2d33
to
39db65c
Compare
|
re-run full centos7-py2 |
|
re-run full debian10-py3 |
dwoz
approved these changes
Nov 6, 2019
Ch3LL
approved these changes
Nov 7, 2019
s0undt3ch
approved these changes
Nov 8, 2019
|
re-run full amazon2-py2 |
|
re-run full centos7-py3-pycryptodomex |
|
re-run full macosxmojave-py2 |
|
re-run full macosxmojave-py3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added
request_intervalkwargs to the http.wait_for_successful_query module to be aligned with the state.What issues does this PR fix or reference?
#53738
Previous Behavior
request_intervalwas not supported in thehttp.wait_for_successful_querymoduleNew Behavior
request_intervalnow supported in thehttp.wait_for_successful_querymoduleTests written?
Yes
Commits signed with GPG?
Yes