Added Elasticsearch cluster settings get and put methods plus the flu… #54917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oloremo
force-pushed
the
elasticsearch-add-cluster-settings-master
branch
from
f9a2401 to
43f3bcd
Compare
ghost
requested a review
from
Oloremo
force-pushed
the
elasticsearch-add-cluster-settings-master
branch
from
1d29009 to
ead8430
Compare
Contributor
|
re-run full debian10-py3 |
dwoz
approved these changes
Nov 6, 2019
Ch3LL
suggested changes
Nov 7, 2019
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
also would you mind add an entry in the CHANGELOG.md file under Added for the neon release. thanks
Oloremo
force-pushed
the
elasticsearch-add-cluster-settings-master
branch
from
13dffc2 to
b7b0fd6
Compare
Contributor
|
@Oloremo not sure if you saw my comment about adding a note to the changelog. This new feature is great and i think would be great to highlight for the neone release. See above for details |
Oloremo
force-pushed
the
elasticsearch-add-cluster-settings-master
branch
from
b7b0fd6 to
109e860
Compare
Contributor
Author
|
@Ch3LL sorry, missed that. Added. |
Ch3LL
approved these changes
Nov 7, 2019
s0undt3ch
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding
get_settingsandput_settingscluster method for Elasticsearch module plus theflush_syncedmethod.What issues does this PR fix or reference?
#54505
Previous Behavior
Elasticsearch module doesn't support these methods
New Behavior
Elasticsearch module does support these methods
Tests written?
Yes
Commits signed with GPG?
Yes