Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Elasticsearch cluster settings get and put methods plus the flu… #54917

Merged

Conversation

Oloremo
Copy link
Contributor

@Oloremo Oloremo commented Oct 7, 2019

What does this PR do?

Adding get_settings and put_settings cluster method for Elasticsearch module plus the flush_synced method.

What issues does this PR fix or reference?

#54505

Previous Behavior

Elasticsearch module doesn't support these methods

New Behavior

Elasticsearch module does support these methods

Tests written?

Yes

Commits signed with GPG?

Yes

@Oloremo Oloremo force-pushed the elasticsearch-add-cluster-settings-master branch from f9a2401 to 43f3bcd Compare Oct 7, 2019
@Oloremo Oloremo requested a review from as a code owner Oct 23, 2019
@ghost ghost requested a review from Akm0d Oct 23, 2019
@Oloremo Oloremo force-pushed the elasticsearch-add-cluster-settings-master branch from 1d29009 to ead8430 Compare Oct 27, 2019
@dwoz
Copy link
Contributor

@dwoz dwoz commented Nov 6, 2019

re-run full debian10-py3
re-run full centos7-py2

dwoz
dwoz approved these changes Nov 6, 2019
Copy link
Contributor

@Ch3LL Ch3LL left a comment

also would you mind add an entry in the CHANGELOG.md file under Added for the neon release. thanks

salt/modules/elasticsearch.py Outdated Show resolved Hide resolved
salt/modules/elasticsearch.py Outdated Show resolved Hide resolved
salt/modules/elasticsearch.py Outdated Show resolved Hide resolved
@Oloremo Oloremo force-pushed the elasticsearch-add-cluster-settings-master branch from 13dffc2 to b7b0fd6 Compare Nov 7, 2019
@Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Nov 7, 2019

@Oloremo not sure if you saw my comment about adding a note to the changelog. This new feature is great and i think would be great to highlight for the neone release. See above for details

@Oloremo Oloremo force-pushed the elasticsearch-add-cluster-settings-master branch from b7b0fd6 to 109e860 Compare Nov 7, 2019
@Oloremo
Copy link
Contributor Author

@Oloremo Oloremo commented Nov 7, 2019

@Ch3LL sorry, missed that. Added.

Ch3LL
Ch3LL approved these changes Nov 7, 2019
@dwoz dwoz merged commit a327f84 into saltstack:master Nov 10, 2019
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants