Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 50302) cmd: Add root parameter for wait and run states #54956

Merged
merged 1 commit into from Dec 11, 2019

Conversation

aplanas
Copy link
Collaborator

@aplanas aplanas commented Oct 11, 2019

What does this PR do?

Add root parameter for a chroot environment to wait and run
states. In the case of run, we delegate the execution to the
run_chroot module.

Tests written?

Yes. Were missing in develop, added for master

(backport #50302, already merged in develop)

salt/states/cmd.py Show resolved Hide resolved
Copy link
Contributor

@waynew waynew left a comment

Hey @aplanas thanks for the PR and tests! Looks good just the one question about exception types.

@aplanas aplanas requested a review from as a code owner Nov 7, 2019
@ghost ghost requested a review from cmcmarrow Nov 7, 2019
Add root parameter for a chroot environment to `wait` and `run`
states. In the case of `run`, we delegate the execution to the
`run_chroot` module.

(cherry picked from commit cd7b5b2)
dwoz
dwoz approved these changes Dec 11, 2019
@dwoz dwoz merged commit 8c2cde3 into saltstack:master Dec 11, 2019
49 checks passed
PRs to port to master automation moved this from PR needs merge to master to PR merged Dec 11, 2019
@aplanas aplanas deleted the backport_50302 branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants