(Backport 50452, 54022) Add new module freezer#54960
Merged
dwoz merged 5 commits intosaltstack:masterfrom Dec 24, 2019
Merged
Conversation
aplanas
force-pushed
the
backport_50452
branch
from
cba3c9f to
a2992d4
Compare
aplanas
changed the title
This was referenced Oct 14, 2019
Contributor
|
Hey @aplanas thanks for the PR and backport - checking this one out now 😃 |
waynew
reviewed
Nov 6, 2019
waynew
reviewed
Nov 6, 2019
waynew
reviewed
Nov 6, 2019
waynew
reviewed
Nov 6, 2019
waynew
reviewed
Nov 6, 2019
waynew
reviewed
Nov 6, 2019
waynew
approved these changes
Nov 6, 2019
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Code-wise, I think this looks great. There are a couple of comments that I don't think are blockers, but I think they could be improved.
aplanas
force-pushed
the
backport_50452
branch
from
a2992d4 to
b26866d
Compare
ghost
requested a review
from
aplanas
force-pushed
the
backport_50452
branch
from
b26866d to
7095ce0
Compare
dwoz
requested changes
Nov 12, 2019
s0undt3ch
approved these changes
Nov 12, 2019
Contributor
s0undt3ch
left a comment
s0undt3ch
left a comment
There was a problem hiding this comment.
Aside from the Copyright removal, I'm cool with this PR.
aplanas
force-pushed
the
backport_50452
branch
from
7095ce0 to
1cb9ee7
Compare
Sometimes we need to have a static picture of the repositories and packages installed in a system, so we can install new transient packages (and the dependencies) and be able to go back to a previous state where those packages are not there anymore. This module allows the user to take this picture, and revert all the changes done after this picture. We can remove package, reinstall packages that are missing, and do the same for repositories. (cherry picked from commit efcce01)
aplanas
force-pushed
the
backport_50452
branch
from
1cb9ee7 to
4e1501a
Compare
Contributor
Author
|
If I split it in two, will help the reviews? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes we need to have a static picture of the repositories
and packages installed in a system, so we can install new transient
packages (and the dependencies) and be able to go back to a previous
state where those packages are not there anymore.
This module allows the user to take this picture, and revert all
the changes done after this picture. We can remove package,
reinstall packages that are missing, and do the same for repositories.
Tests written?
Yes
(backport #50452, already merged in develop)
(backport #54022, under review)