Merged
Conversation
initial xml module/state
include xml state/module in docs
waynew
reviewed
Nov 6, 2019
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Thanks for the PR! Code looks great - a couple of questions about the comments, though.
waynew
added
the
pending-discussion
dwoz
requested changes
Nov 7, 2019
ghost
requested a review
from
waynew
reviewed
Dec 26, 2019
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
I think code-wise, this looks good now. Just a couple of tweaks and it looks ready for merge.
waynew
reviewed
Dec 30, 2019
Contributor
Author
|
test failures appear to be unrelated to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports #49822 and #52217 to master branch
Tests written?
Yes - as originally included
Note: this includes the release notes from Neon as of when this was committed. Might be a conflict'y item in this process.