-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master-port #52441 #54985
Master-port #52441 #54985
Conversation
cron return a single line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs some tests.
It's a good candidate for unit tests - patch list_tab to return sample data, then verify that it breaks if cmd and identifier are specified, and works if identifier or cmd are specified.
Is it possible for the same identifier to occur multiple times in the crontab? What about the same command at different intervals?
Apologies, I started that review weeks ago but I waited for the PR route but both were closed. |
@mchugh19 Can you address the comments? |
Added tests and @myii's changes. I think this should be good to go! |
re-run pr-py3-centos-8 |
re-run pr-ubuntu1604-py3-m2crypto |
re-run pr-ubuntu1604-py2-m2crypto |
re-run pr-amazon2-py2 |
There are no py2 anymore. I've updated the branch to force refreshing of the tests list. |
cron return a single line
What does this PR do?
Ports #52441 to master
Add get_entry to cron module to return a single cron entry. This allows for use in tools like saltcheck: