Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 51871) cmdmod: add 'binds' parameter in run_chroot #54996

Merged
merged 2 commits into from Dec 4, 2019

Conversation

aplanas
Copy link
Collaborator

@aplanas aplanas commented Oct 14, 2019

What does this PR do?

Sometimes we want to export directories from the system to the
chroot environment. For example, some services will require the
presence of /run inside the chroot, to request some PID information.

This patch add a new 'binds' parameter in the run_chroot function,
that will export those system directories into the chroot.

Tests written?

Yes, added in this PR

(backport #51871, already merged in develop)

@waynew waynew added this to PR needs merge to master in PRs to port to master Oct 17, 2019
@waynew waynew self-assigned this Nov 5, 2019
salt/modules/cmdmod.py Show resolved Hide resolved
@waynew
Copy link
Contributor

@waynew waynew commented Nov 6, 2019

@aplanas thanks for adding the tests and getting the backport. Looks like this is out of date with master, would you mind rebasing?

I know at least one of these failures is a flaky test that we've been working on, that shouldn't block the PR from merging. Hopefully with the rebase we should see that test pass.

@aplanas aplanas requested a review from as a code owner Nov 7, 2019
@ghost ghost requested a review from dwoz Nov 7, 2019
aplanas added 2 commits Dec 3, 2019
Sometimes we want to export directories from the system to the
chroot environment.  For example, some services will require the
presence of /run inside the chroot, to request some PID information.

This patch add a new 'binds' parameter in the run_chroot function,
that will export those system directories into the chroot.

(cherry picked from commit b6a4394)
dwoz
dwoz approved these changes Dec 4, 2019
@dwoz dwoz merged commit 01f84ed into saltstack:master Dec 4, 2019
49 checks passed
PRs to port to master automation moved this from PR needs merge to master to PR merged Dec 4, 2019
@aplanas aplanas deleted the backport_51871 branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants