-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Allow to pass arguments to fileserver.update runner #55014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e0f625d
to
f58e484
Compare
@twangboy @waynew @terminalmage Please review 👓 |
0e99f8e
to
70ff03d
Compare
@dwoz I've added tests (and rebased). |
70ff03d
to
17a05a6
Compare
@sathieu thanks for the PR and sorry for the delay in getting this reviewed! I've merged the most recent master changes in. Next week we're going to be pretty busy with some planning, but I've written this down to make sure we get this looked at by 2nd week in March (2 weeks from now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also get test for the changes you made in gitfs?
76b30d1
to
f5cebf2
Compare
@sathieu I brought this up with the team, and With If you want to avoid having to provide an argument, default arguments are OK! Let me know if you have any questions! |
f5cebf2
to
c109964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update these to no longer take **kwargs
?
1313fbc
to
6366c5d
Compare
6366c5d
to
d7695a2
Compare
I've added a test to ensure that invalid parameters throw an error. Remaining todo:
|
d990575
to
a762f35
Compare
@waynew @dwoz @cmcmarrow @twangboy Please review. |
a762f35
to
2ba7a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable to me - I'll bring it up to the rest of the team.
@sabaini thanks for adding tests. This should get merged shortly after sodium gets released. |
@cmcmarrow I've added the tests 😄 |
2ba7a12
to
caaaee1
Compare
@cmcmarrow You've marked this PR Merge Ready. I've now rebased and fixed |
@sagetherage You've removed the Merge Ready tag here. What can I do help merging this PR (and others #56316, #57288)? |
we removed that label all together from the project as it doesn't mean what it says - this needs to be rebased with master, and needs a completed review. |
@sagetherage @cmcmarrow @waynew @twangboy Any chance to get this reviewed and merged soon? It was marked merge-ready few months ago... Thanks |
The team is working on getting the test suite to green overall and then merging will start, again. I haven't updated the branch since the branch builds are failing, so I will get back to this soon. |
@twangboy @sagetherage Hello. Sorry to insist, but can this be merged in magnesium ? This MR exists since Oct 2019. NB: I've merged master and resolved the conflict. |
This is useful to only update one GitFS remote.
6f0a3f9
to
7981e66
Compare
What does this PR do?
Allow to pass arguments to fileserver.update runner
This is useful to only update one GitFS remote.
What issues does this PR fix or reference?
None. But #53622 is related.
Previous Behavior
No way to only update one GitFS repo.
Tests written?
No
Commits signed with GPG?
No