Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Allow deprecating by date #55047

Merged
merged 2 commits into from Oct 19, 2019

Conversation

s0undt3ch
Copy link
Member

@s0undt3ch s0undt3ch commented Oct 17, 2019

What does this PR do?

Allow deprecating by date. Includes tests.

What issues does this PR fix or reference?

Previous Behavior

We could only deprecated by version names

New Behavior

We can now deprecate based on dates

Tests written?

Yes

Commits signed with GPG?

Yes

@s0undt3ch s0undt3ch requested a review from dwoz Oct 17, 2019
salt/utils/versions.py Outdated Show resolved Hide resolved
dwoz
dwoz approved these changes Oct 17, 2019
@s0undt3ch s0undt3ch force-pushed the features/time-based-deprecation branch from 32c39bd to bc680e2 Compare Oct 18, 2019
@s0undt3ch s0undt3ch requested review from twangboy and dwoz Oct 18, 2019
@s0undt3ch
Copy link
Member Author

@s0undt3ch s0undt3ch commented Oct 18, 2019

Updated PR. We don't have to patch under Py3.

@s0undt3ch s0undt3ch force-pushed the features/time-based-deprecation branch from bc680e2 to a6bb8c8 Compare Oct 18, 2019
@s0undt3ch s0undt3ch force-pushed the features/time-based-deprecation branch 2 times, most recently from 8857c83 to 54f5117 Compare Oct 18, 2019
Akm0d
Akm0d approved these changes Oct 18, 2019
@s0undt3ch s0undt3ch force-pushed the features/time-based-deprecation branch from 54f5117 to e5cd1a2 Compare Oct 18, 2019
waynew
waynew approved these changes Oct 18, 2019
salt/utils/versions.py Show resolved Hide resolved
dwoz
dwoz approved these changes Oct 19, 2019
@dwoz dwoz merged commit 340c0b5 into saltstack:master Oct 19, 2019
34 of 35 checks passed
@s0undt3ch s0undt3ch deleted the features/time-based-deprecation branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants