[master] Allow deprecating by date #55047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
requested changes
Oct 17, 2019
dwoz
approved these changes
Oct 17, 2019
twangboy
approved these changes
Oct 17, 2019
s0undt3ch
force-pushed
the
features/time-based-deprecation
branch
from
32c39bd
to
bc680e2
Compare
|
Updated PR. We don't have to patch under Py3. |
s0undt3ch
force-pushed
the
features/time-based-deprecation
branch
from
bc680e2
to
a6bb8c8
Compare
s0undt3ch
force-pushed
the
features/time-based-deprecation
branch
2 times, most recently
from
8857c83
to
54f5117
Compare
Akm0d
approved these changes
Oct 18, 2019
s0undt3ch
force-pushed
the
features/time-based-deprecation
branch
from
54f5117
to
e5cd1a2
Compare
waynew
approved these changes
Oct 18, 2019
dwoz
reviewed
Oct 18, 2019
dwoz
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow deprecating by date. Includes tests.
What issues does this PR fix or reference?
Previous Behavior
We could only deprecated by version names
New Behavior
We can now deprecate based on dates
Tests written?
Yes
Commits signed with GPG?
Yes